Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(725)

Issue 13971043: Fix a couple errors in the gyp build scripts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Jamie Madill
Modified:
2 months, 2 weeks ago
CC:
angleproject-review_googlegroups.com
Base URL:
https://code.google.com/p/angleproject/@master
Visibility:
Public.

Description

Fix some syntax errors in the gyp build configuration, and make some modifications so the tests should work with chromium in component build. We use a separate static translator for linking directly with unit tests, so they have more direct access to the translator classes. ANGLEBUG=477 BUG= R=shannonwoods@chromium.org, zmo@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=8935267

Patch Set 1 #

Patch Set 2 : Fix compile errors in standalone build. #

Total comments: 1

Patch Set 3 : Restore the translator component build. #

Patch Set 4 : Fix component build, but still breaks WebKit. #

Patch Set 5 : Disable component build for the static translator #

Patch Set 6 : Defer component build fix for later. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -74 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/GLSLANG/ShaderLang.h View 1 2 3 4 5 1 chunk +1 line, -1 line 1 comment Download
M samples/build_samples.gyp View 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/build_angle.gypi View 1 2 3 4 6 chunks +104 lines, -66 lines 0 comments Download
M tests/build_tests.gyp View 1 4 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7
Shannon Woods
LGTM, though you may want to wait for Mo's LGTM, as I'm not as gyp-fluent.
11 years, 2 months ago (2013-09-26 14:53:58 UTC) #1
Zhenyao Mo
https://codereview.appspot.com/13971043/diff/4001/src/build_angle.gypi File src/build_angle.gypi (left): https://codereview.appspot.com/13971043/diff/4001/src/build_angle.gypi#oldcode184 src/build_angle.gypi:184: 'target_name': 'translator', We will want to get rid of ...
11 years, 2 months ago (2013-09-26 16:58:46 UTC) #2
Jamie Madill
On 2013/09/26 16:58:46, Zhenyao Mo wrote: > https://codereview.appspot.com/13971043/diff/4001/src/build_angle.gypi > File src/build_angle.gypi (left): > > https://codereview.appspot.com/13971043/diff/4001/src/build_angle.gypi#oldcode184 ...
11 years, 2 months ago (2013-09-26 17:01:12 UTC) #3
Zhenyao Mo
LGTM
11 years, 2 months ago (2013-09-27 00:15:07 UTC) #4
Zhenyao Mo
https://codereview.appspot.com/13971043/diff/15001/include/GLSLANG/ShaderLang.h File include/GLSLANG/ShaderLang.h (right): https://codereview.appspot.com/13971043/diff/15001/include/GLSLANG/ShaderLang.h#newcode9 include/GLSLANG/ShaderLang.h:9: #if (COMPONENT_BUILD) I verified on linux this is false ...
11 years, 2 months ago (2013-09-27 00:27:19 UTC) #5
Jamie Madill
Committed patchset #6 manually as r8935267 (presubmit successful).
11 years, 2 months ago (2013-09-27 20:51:10 UTC) #6
ruvalcabafrancisco588
2 months, 2 weeks ago (2024-09-19 00:18:15 UTC) #7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b